Dummy app test setup improvements #57
Conversation
codyrobbins
force-pushed
the
dummy-app-test-setup-improvements
branch
from
4af59cd to
d1283ae
Compare
… suite locally and changed the GitHub Actions workflow to leverage the new setup script.
codyrobbins
force-pushed
the
dummy-app-test-setup-improvements
branch
from
d1283ae to
6078cbf
Compare
|
Update: It looks like this works on GitHub Actions (after a few minor fixes)! |
|
I appreciate the effort on this! 🎉 🚀 And I'm sorry to hear of your struggles to run the suite locally - this is something that definitely should've been documented! I cherry-picked your README change and edited it to reflect the current reality of testing: 166f0ba As mentioned in that change, to test the dummy app locally I use https://github.com/nektos/act which runs the GitHub workflow/action locally using Docker. This used to be really simple like 6 months ago; I could just do And it would work fine. But I recently updated to the latest If you only want to run against certain versions of Ruby or Rails you can use the That said, I see the value in your script and would be happy to accept your PR with a couple changes!
If you need to re-push / force push to re-run GitHub actions/workflows that's no problem, just let me know when you think it's ready Thanks! |
|
(Copying and pasting this to all open issues/PRs:) Hey all, per #64 I unfortunately won't have much time for the foreseeable future to maintain devise-passwordless to fix the open bugs and work on new features. I'm not abandoning this project, but due to some life issues it's just at the bottom of my priority list for now. Anyone who wants to step up and be a maintainer to shepherd the project forward would be welcomed! I just ask that you've opened a PR, or written an issue, or can otherwise demonstrate some familiarity/competence with the project. You can reply to #64 or message me privately (through email or socials since GitHub doesn't have DMs) if interested. Thank you ✌️ |
I struggled a bit getting the dummy app test suite running locally. The commands in the GitHub Actions config file didn’t work for me for a variety of reasons, probably due to Bundler version and configuration differences and having
asdfin the mix. Once I got it working on my machine, I moved the commands intobin/dummy-app-setupand modified the GitHub Actions workflow to call this script.I think this dummy app setup script is more general and can now be called locally on anyone’s machine to prepare the dummy app for running the test suite. I changed the directory structure created slightly to ensure that the gem’s development dependencies, the
railsgem installation used to callrails new, and the dummy app gem dependencies are all firewalled off from each other. This doesn’t matter when running via GitHub Actions, but was a big part of the problem when trying to run locally. The modified directory structure also allows dummy apps for multiple versions of Rails to coexist inspec/tmp/dummy_app-rails-VERSION/dummy_app.It’s possible these changes might be depending on quirks of my own local development environment, though, so I’m not sure if this will run correctly on GitHub Actions or your own machine. But if the kinks can be worked out I think this will improve the development experience for anyone else contributing!